-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed deployment issue with xloader version 1.2.0 #802
Conversation
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM ckan/ckan-dev:2.10.5-py3.10 | |||
FROM --platform=linux/amd64 ckan/ckan-dev:2.10.5-py3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this build on M-series Macs? I've been struggling with this separately and I don't know the best way to support multiple platform architectures in code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works on M-series Macs. This flag specifies the target platform of the container (Linux in this case), not the host OS where Docker is running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this setting to avoid complexity, as individual users can configure it in their local environment.
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM ckan/ckan-dev:2.10.5-py3.10 | |||
FROM --platform=linux/amd64 ckan/ckan-dev:2.10.5-py3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this to an env var instead? DOCKER_DEFAULT_PLATFORM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this setting to avoid complexity, as individual users can configure it in their local environment.
fixed deployment issue with xloader version 1.2.0
Pull Request