Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed deployment issue with xloader version 1.2.0 #802

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

Jin-Sun-tts
Copy link
Contributor

Pull Request

  • Added a platform option in the Dockerfile to ensure compatibility with macOS.
  • Pinned the version of ckanext-xloader to prevent deployment issues.

@Jin-Sun-tts Jin-Sun-tts requested a review from a team January 28, 2025 14:46
Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM ckan/ckan-dev:2.10.5-py3.10
FROM --platform=linux/amd64 ckan/ckan-dev:2.10.5-py3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this build on M-series Macs? I've been struggling with this separately and I don't know the best way to support multiple platform architectures in code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works on M-series Macs. This flag specifies the target platform of the container (Linux in this case), not the host OS where Docker is running.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this setting to avoid complexity, as individual users can configure it in their local environment.

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM ckan/ckan-dev:2.10.5-py3.10
FROM --platform=linux/amd64 ckan/ckan-dev:2.10.5-py3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to an env var instead? DOCKER_DEFAULT_PLATFORM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this setting to avoid complexity, as individual users can configure it in their local environment.

@Jin-Sun-tts Jin-Sun-tts merged commit e028992 into main Jan 29, 2025
6 checks passed
@Jin-Sun-tts Jin-Sun-tts deleted the fix-deployment-issue branch January 29, 2025 16:33
FuhuXia pushed a commit that referenced this pull request Feb 10, 2025
fixed deployment issue with xloader version 1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants