Fix touch event cleanup #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartzis
commented
Mar 21, 2019
src/index.js
Outdated
|
|
||
| // if new DOM el clean up old DOM and reset cleanUpTouch | ||
| if (state.el && state.el !== el && state.cleanUpTouch) { | ||
| newState.cleanUpTouch = state.cleanUpTouch() |
There was a problem hiding this comment.
instead of setting up newState, do a transientState?
const transientState = {}
if (state.el && state.el !== el && state.cleanUpTouch) {
state.cleanUpTouch()
transientState.cleanUpTouch = null
}
...
return {...state, ...transientState}
Then we can be more conistent and clear with using state for checking and transientState for updating?
| @@ -21,7 +21,7 @@ | |||
| }, | |||
| "size-limit": [ | |||
| { | |||
| "limit": "1.8 KB", | |||
| "limit": "1.875 KB", | |||
There was a problem hiding this comment.
annoying we need to increase this, but the benefit I believe is a more understandable solution and easier code to reason about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right before i was about to release
5.1.0found that the #131 added a bug where touch events were not being "cleaned up" iftrackTouchwas toggled. This pr "cleans up" the touch event listeners.published as
[email protected]size-limittoo, just a bit with room to breath