SDKS-3395 - Align naming and errors for Davinci #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
120371a to
8cc16d1
Compare
witrisna
reviewed
Oct 7, 2024
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
8cc16d1 to
3473a77
Compare
witrisna
reviewed
Oct 7, 2024
| } | ||
|
|
||
| // Treat unknown status codes as unrecoverable failures | ||
| return FailureNode(cause: ApiError.error(status, json, message)) |
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
3473a77 to
313c59e
Compare
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
313c59e to
8f275ff
Compare
jeyanthanperiyasamy
requested review from
george-bafaloukas-forgerock and
rodrigoareis
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
8f275ff to
2130ddd
Compare
vahancouver
requested changes
Oct 10, 2024
| @@ -11,7 +11,7 @@ | |||
| import PingOrchestrate | |||
|
|
|||
| /// Extension to get the id of a Connector. | |||
There was a problem hiding this comment.
update documentation to reflect the new name
| } | ||
|
|
||
| /// Protocol for Node. Represents a node in the workflow. | ||
| public protocol Node {} | ||
|
|
||
| public struct EmptyNode: Node { | ||
| public init() {} | ||
| public init() {} | ||
| } | ||
|
|
||
| /// Represents an error node in the workflow. | ||
| /// - property cause: The cause of the error. |
There was a problem hiding this comment.
update documentation to reflect the new name
|
|
||
| public let input: [String: Any] | ||
| public let message: String | ||
| public struct ErrorNode: Node { |
There was a problem hiding this comment.
update documentation to reflect the new name
| static let status = "status" | ||
| static let authorizeResponse = "authorizeResponse" | ||
| static let code = "code" | ||
| static let codeNumber = 1999 |
There was a problem hiding this comment.
can the name reflect the value? code_1999 or something like that
| static let connectorId = "connectorId" | ||
| static let capabilityName = "capabilityName" | ||
| static let requestTimedOut = "requestTimedOut" | ||
| static let pingOneAuthConnector = "pingOneAuthenticationConnector" |
There was a problem hiding this comment.
to be consistent, I'd suggest to name the variable exactly like the value where possible to avoid any duplicates or confusion later.
|
All comments addressed |
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
2130ddd to
484813a
Compare
vahancouver
requested changes
Oct 16, 2024
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
484813a to
27d8636
Compare
|
updated read me |
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
27d8636 to
3ad99b7
Compare
spetrov
approved these changes
Oct 16, 2024
jeyanthanperiyasamy
force-pushed
the
SDKS-3395
branch
from
3ad99b7 to
816ac8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-3395 DaVinci Errors and naming