Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple versions #11

Merged

Conversation

wesleytodd
Copy link
Contributor

@wesleytodd wesleytodd commented Oct 14, 2017

Adds support for testing with multiple versions of path-to-regxp. Also adds some build stuff and standard formatting. I can do separate PRs for them if you would prefer that.

Reference: https://wesleytodd.github.io/express-route-tester/

@wesleytodd
Copy link
Contributor Author

Ok, added some error handling because some inputs will cause path-to-regexp to throw and the version in express@4 can return number keys, so it crashed the escape function. All of that should be fixed, and I added new display for when the regexp compilation fails.

@wesleytodd wesleytodd force-pushed the multiple-versions branch 2 times, most recently from 494c5b3 to e4a1fe5 Compare October 14, 2017 01:55
Copy link

@rjmunro rjmunro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work. Please can it be merged ASAP. Particularly that it defaults to the same version as express actually uses, and that it displays when the regex won't compile.

@ForbesLindesay ForbesLindesay merged commit f39c57f into ForbesLindesay:gh-pages Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants