Drop support for Julia 1.6 #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the are some |
CarloLucibello
approved these changes
Jan 6, 2025
devmotion
reviewed
Jan 7, 2025
.github/workflows/ci.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| version: | |||
| - '1.6' # Replace this with the minimum Julia version that your package supports. | |||
| - '1.10' # Replace this with the minimum Julia version that your package supports. | |||
There was a problem hiding this comment.
You could update setup-julia to v2 and use
Suggested change
| - '1.10' # Replace this with the minimum Julia version that your package supports. | |
| - 'min' |
ToucheSir
reviewed
Jan 24, 2025
| @@ -17,7 +17,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| version: | |||
| - '1.6' # Replace this with the minimum Julia version that your package supports. | |||
There was a problem hiding this comment.
While we're modifying CI config, could we bump the versions of actions and switch over to the more useful https://github.com/julia-actions/cache?
|
Should we merge this PR? I can then add a parallelized testing which would be much easier with Julia 1.9+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No very strong reason, could wait until someone has a bug which is simpler to solve without fixing 1.6