Revert "Makefile: only use dune --release on release builds" #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, building the library without the --release flag makes a dune build call in everparse for the ASN1 parser explode with a stack overflow: ``` $ dune clean && fstar.exe --ocamlenv dune build File "dune", lines 3-9, characters 0-113: 3 | (executable 4 | (name ASN1_Parser) 5 | (libraries 6 | fstar.lib 7 | ) 8 | (flags (:standard -w -8-9-11-26-27-33-39-20)) 9 | ) Fatal error: exception Stack overflow ``` This is during compilation of the ASN1_X509.ml module, which is 58k lines long, and the offending function where the crash happens (dparse_cert) is 28k lines long. This is probably hitting some limitation of ocamlopt, but also a reminder that we should try to generate more compact code. For now, just revert this, and pay some time in development builds. This reverts commit 1ac7ed0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, building the library without the --release flag makes a dune build call in everparse for the ASN1 X.509 parser explode with a stack overflow:
This is during compilation of the ASN1_X509.ml module, which is 58k lines long, and the offending function where the crash happens (dparse_cert) is 28k lines long.
This is probably hitting some limitation of ocamlopt, but also a reminder that we should try to generate more compact code. For now, just revert this, and pay some time in development builds.
This reverts commit 1ac7ed0.
cc @tahina-pro , this showed up in the everest build.