Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mem_filter stronger #3200

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Make mem_filter stronger #3200

merged 5 commits into from
Mar 19, 2024

Conversation

chandradeepdey
Copy link
Contributor

@chandradeepdey chandradeepdey commented Jan 30, 2024

  • Mirrors TSet
  • Remove the refinement on the return type of filter, it was implied by the SMTPat on mem_filter_forall anyway

@chandradeepdey chandradeepdey changed the title Make the postcondition on filter stronger Make mem_filter stronger Feb 13, 2024
- Mirrors TSet
- Remove the refinement on the return type of filter, it was implied
  by the SMTPat on mem_filter_forall anyway
@chandradeepdey
Copy link
Contributor Author

@aseemr Check this one please?

@aseemr
Copy link
Collaborator

aseemr commented Mar 19, 2024

Hi @chandradeepdey, thanks for the PR!

I merged master into this branch and F* build fails. It could be some brittleness in the proofs.

If we make F* work, I would also like to run our everest CI on it to make sure that we are not breaking any of the client code in everest. If something breaks there, we would have to fix that too.

On the other hand, if you can make things work on your end using some wrappers or locally defined patterns, perhaps that's a quicker way to make progress.

@chandradeepdey
Copy link
Contributor Author

chandradeepdey commented Mar 19, 2024

@aseemr Builds now!

On the other hand, if you can make things work on your end using some wrappers or locally defined patterns, perhaps that's a quicker way to make progress.

I have it in my code already. Wanted to push it here so I could delete it from there 😅

@aseemr
Copy link
Collaborator

aseemr commented Mar 19, 2024

Thanks! I started a local everest build on my machine.

@aseemr aseemr merged commit 41299bb into FStarLang:master Mar 19, 2024
2 checks passed
@chandradeepdey chandradeepdey deleted the filter branch March 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants