Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RapidJSON with nlohmann::json #1277

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Replace RapidJSON with nlohmann::json #1277

wants to merge 3 commits into from

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Mar 5, 2025

RapidJSON has become outdated, which has led to increasing maintenance issues.

Static lib builds, but a breaking change is causing 1 test to fail (decision required).

Breaking Changes

  • nlohmann json outputs nan/inf as null (this is compatible with how some big js lib works). This means we can't read them back to their original broken value. IOTest.JSON_WriteRead needs amending to account for this, or we need to fudge all float export to actually output it as a string manually.
  • nlohmann json outputs empty objects as null, so we're better off ommitting them from our json (e.g. if there are no macro env properties to be logged.

Robadob added 3 commits March 5, 2025 22:23
RapidJSON has become outdated, which has led to increasing maintenance issues.
Still need to decide how to address nan/inf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant