BugFix: JSONStateWriter prettyprint output is nolonger minified. #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapidjson's PrettyWriter extends Writer, but methods are non-virtual, leading to former bug. This fix is best solution of the bad options (heavy templating, dual internal writers). Closes #1231
Robadob
force-pushed
the
bugfix_json_prettyprint
branch
from
dfc6628 to
289ff23
Compare
Would have broken if it encounterd an odd number of nested quotes within a string.
ptheywood
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
A test would be prefferred but understandable why you haven't with our current time limitations.
Maybe add it to #1050 so it can be added in the future if time allows?
Otherwise looks sensible and appears to behave as intended under linix via a manual check of test.json.
|
This might not support single quotes but is less broken than before so suggest to merge and raise a new bug if it comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidjson's
PrettyWriterextendsWriter, but methods are non-virtual, leading to the bug which has been resolved.This fix is the best solution of the bad options (e.g. heavy templating or dual internal writers/
std::variantwith an if/cast every time a method is called) given this implementation's modular approach to writing.I have tested this works manually, I have no plans to write a test that parses the output to check whether it's minified or not as it would essentially be an inverse of the parsing rules I've written unless you had ground truths to compare against for a specific input. But you can if that's your prerogative.
JSONLoggerdoes not suffer from the same bug, I have a feeling it was noticed when that was implemented and worked around.Closes #1231