Refactor code so that the git repo to use is controlled by the UI and is passed into the API #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgelenas
requested changes
Oct 22, 2021
justinlampley
force-pushed
the
TXBackpack
branch
2 times, most recently
from
bf5e094 to
be78c40
Compare
jurgelenas
requested changes
Oct 23, 2021
| this.config.git.repositoryName | ||
| ); | ||
| async gitBranches( | ||
| @Arg('owner') owner: string, |
There was a problem hiding this comment.
You could have a shared args class across all these methods, but it is up to you.
…assed into the api.
…be specified on a per repo basis.
…nterfaces instead of directly using GraphQL objects.
…ame into which the firmware will be downloaded.
justinlampley
force-pushed
the
TXBackpack
branch
from
c6a6f42 to
93274db
Compare
… instead of being part of other args and inputs.
jurgelenas
approved these changes
Oct 26, 2021
This was referenced Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor pulls out the git repo configuration from the API layer and moves it to the UI so the UI can request data from multiple repositories. It also moves the taq exclusion out of the GitHubClient and makes it a configurable property on the repository class.