-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add localization support #523
Conversation
Overall it looks very good! I'll look at doing a more comprehensive review later, but there are a few things I noticed after a quick look through the changes.
|
2. fix typos 3. complex text that includes react components 4.
|
2. Fixed a typo in translation file en.json 3. Improved one zh-CN localization.
|
@L1cardo can you please look into making translation type-safe according to https://www.i18next.com/overview/typescript ? |
I have created a project on Will work on this: https://support.crowdin.com/github-integration/ |
2. remove `TODO: translations`
2. add a simple language switcher
For github and crowding integration, crowdin official integration only sync at the first time and we should manually sync every time after. https://support.crowdin.com/github-integration/#uploading-translations-from-repo. |
@L1cardo can you resolve merge conflicts? |
This reverts commit ddc4498.
|
I forgot to add
![]()
![]() |
#463


Works well on macOS, but need to be tested on Win and Linux.