Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] LHN-LHN message previews include WS name after creating the second workspace #58186

Open
3 of 8 tasks
mitarachim opened this issue Mar 11, 2025 · 6 comments
Open
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@mitarachim
Copy link

mitarachim commented Mar 11, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57911
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome, Samsung s10/ Android 12
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Navigate to https://staging.new.expensify.com
  2. Log in with new Account and create 1 WS (Important step)
  3. Navigate to admin room of a workspace
  4. Send a message (Eg. HI)
  5. Observe the LHN
  6. Notice their is only "you: HI" in preview(LHN)
  7. Create another WS
  8. Navigate back to the LHN and notice step 7 Preview now add WS name

Expected Result:

LHN preview should contain the WS name in the admin room without expecting other WS addition.

Actual Result:

LHN preview contain the WS name in the admin room only when other WS created.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6766886_1741660998032.Screen_Recording_20250311_052143_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021899731094514102598
  • Upwork Job ID: 1899731094514102598
  • Last Price Increase: 2025-03-12
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 11, 2025
Copy link

melvin-bot bot commented Mar 11, 2025

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@daledah
Copy link
Contributor

daledah commented Mar 11, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN preview contain the WS name in the admin room only when other WS created.

What is the root cause of that problem?

we are checking if there are less than 2 workspaces we'll return prefix as ''

App/src/libs/ReportUtils.ts

Lines 4600 to 4603 in 76140d4

const filteredPolicies = Object.values(allPolicies ?? {}).filter((policy) => shouldShowPolicy(policy, false, currentUserEmail));
if (filteredPolicies.length < 2) {
return '';
}

What changes do you think we should make in order to solve the problem?

We should remove this condition

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add tests for the function getReportSubtitlePrefix to confirm that if we have one workspace we need to return prefix

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Mar 12, 2025
Copy link

melvin-bot bot commented Mar 12, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021899731094514102598

@melvin-bot melvin-bot bot changed the title LHN-LHN message previews include WS name after creating the second workspace [$250] LHN-LHN message previews include WS name after creating the second workspace Mar 12, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 12, 2025
Copy link

melvin-bot bot commented Mar 12, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@ZhenjaHorbach
Copy link
Contributor

@daledah
Thanks for your proposal !

Your proposal makes sense to me !
🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Mar 12, 2025

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants