-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Feature request : Upgrade task titles with markdown rendering #53175
Comments
Triggered auto assignment to @muttmuure ( |
@muttmuure Eep! 4 days overdue now. Issues have feelings too... |
Job added to Upwork: https://www.upwork.com/jobs/~021863958075863531330 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Hm, why hasn't this had any proposals? Also, why is the job listing "private"? |
Upwork job price has been updated to $500 |
The job shows as public to me in Upwork. |
Edited by proposal-police: This proposal was edited at 2024-12-07 22:35:47 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Feature request : Upgrade task titles with markdown rendering What is the root cause of that problem?New feature What changes do you think we should make in order to solve the problem?
Test Branch
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?What alternative solutions did you explore? (Optional)
ResultMonosnap.screencast.2024-12-07.10-42-17.mp4 |
@mananjadhav 👀 plz on the proposal above. Thx |
Yes I had reviewed the proposal partially on the weekend. The proposal looks good, minor code changes and other areas to make updates can be covered in the implementation. 🎀 👀 🎀 |
Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Nice! I think that's exactly what @shawnborton was describing. |
Yes, that looks great to me! Can you show us what some |
inline code rendering: inline_code_block_title_rendere.mp4 |
Nice, that seems good to me - thanks! |
@roryabraham, the frontend part is almost done. Is there anything left in the backend PR? From the API response, everything seems to be working. |
@mananjadhav Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
PR is WIP. |
Looking for engineering volunteer: https://expensify.slack.com/archives/C03TQ48KC/p1740777106523109 |
@Expensify/design, a few things came up while recording the videos for platforms:
Monosnap.screencast.2025-03-01.07-03-32.mp4
web_chrome.mp4 |
@mananjadhav, you can start reviewing the PR now. |
Keen on @Expensify/design thoughts as well. This is becoming pretty hectic, but I guess it's still working. Part of me still kinda wishes we just stuck with links and italics 😂 |
Yup, I agree with everything Jon is saying above. And yeah, I agree that this is feeling slightly silly... but maybe we start with allowing full markdown control here, and then we can scale back if we find it to be an issue. I have a feeling most of our users don't even use markdown or aren't familiar with it. |
Yeah, I'm okay with that 👍 |
I also agree with Jon and Shawn's thoughts. I'm fine starting with all of it and then scaling back. |
Hi! This project seems stuck, so I've asked @Krishna2323 some questions in Slack here: https://expensify.slack.com/archives/C01GTK53T8Q/p1741054265831269?thread_ts=1734840786.675329&cid=C01GTK53T8Q -- I'd love to get a better understanding of where we are currently at with the front end, so we can identify exactly what needs to happen on the back end. |
Seems like @roryabraham has reviewed #54165 and left comments, and @Krishna2323 is responding to those comments. Once resolved, we can merge. |
Bumped again -- I think we should ship what we've got, remaining issues aren't blockers. |
Merged and going out on Monday! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: New Feature
Reproducible in production?: New Feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): ts_external_expensify_convert
Background: The primary use of tasks today is Concierge assigning a specific set of onboarding task to the user. Each task currently has a numbered list of steps, generally ending with a link we want them to click. However, we see that some users don't realize the task can be clicked, meaning they don't see the instructions, meaning they don't click the link.
Problem: When new users don't realize the task title is clickable, they don't see the instructions, and thus don't do the call to action.
Solution: Please render task names using the same markdown>html processing as we do normal comments, to allow hyperlinks to be put into titles, in order to shorten the path to the CTA to one click. In other words, make task titles work like task descriptions:
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mananjadhavThe text was updated successfully, but these errors were encountered: