[Due for payment 2025-02-18] [$250] Search - Self DM is removed from top of search list when email is fully typed out in query

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/26723&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open search
2. Type out the gmail adress of the account you are logged in as
3. Observe that while typing the gmail out "you" account is listed first but as soon as you type the gmail fully "you" account isnt the first item in the list

Expected Result:

"You" account should be listed first

Actual Result:

"You" account isnt listed first when gmail adress of the account is fully typed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6644107_1729755835920.scrnli_GFnBU50NZYqeaq.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882098792148557687
• Upwork Job ID: 1882098792148557687
• Last Price Increase: 2025-01-22
• Automatic offers:
• DylanDylann | Reviewer | 105937420
• FitseTLT | Contributor | 105937421

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[OfstadC]

Can't reproduce. I also couldn't reproduce using an account with multiple other workspace members and chats.

[OfstadC]

Tested again and can't reproduce. Closing

[lanitochka17]

Issue is still reproducible again on the latest build 9.0.87-0
Try to check with an account that has several conversation, workspaces and requests for money

[OfstadC]

Thanks @lanitochka17. I'll give it another shot 😃

[melvin-bot]

@OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[OfstadC]

Wildly now I can't even find myself at all to DM - [email protected]

[OfstadC]

But I can under my private domain accounts 🤔

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882098792148557687

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Self DM is removed from top of search list when email is fully typed out in query

What is the root cause of that problem?

We put self dm on top by returning 0 here

App/src/libs/OptionsListUtils.ts

Lines 1078 to 1079 in fc199fa

	if (option.isSelfDM) {
	return 0;

so now until we write the full login in the search the other reports where the logins are the same as the self dm (current user) will be ordered just below the self dm because we return 1 here when the login is not equal to the search

App/src/libs/OptionsListUtils.ts

Lines 1096 to 1098 in fc199fa

	if (option.login.toLowerCase() !== searchValue?.toLowerCase()) {
	return 1;
	}

but as soon as the search becomes equal to the login the other reports will have the same order value of 0 as the self dm via this line

App/src/libs/OptionsListUtils.ts

Lines 1100 to 1101 in fc199fa

	// When option.login is an exact match with the search value, returning 0 puts it at the top of the option list
	return 0;

What changes do you think we should make in order to solve the problem?

To put the self dm on top of other reports we should return a lower value than 0 here

App/src/libs/OptionsListUtils.ts

Lines 1078 to 1079 in fc199fa

	if (option.isSelfDM) {
	return 0;

if (option.isSelfDM) {
                    return -1;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test orderReportOptionsWithSearch to ensure it returns self dm on top of the list though the login of other options are equal to the search.

What alternative solutions did you explore? (Optional)

[DylanDylann]

@FitseTLT's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@madmax330, @OfstadC, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[FitseTLT]

Bump for an assignment @madmax330

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Search - Self DM is removed from top of search list when email is fully typed out in query #56171

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @OfstadC @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@DylanDylann please complete the BZ checklist by the payment date 😃 - Thank you!

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Put self DM at the top of search result #42704 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Open search
2. Type out the gmail adress of the account you are logged in as
3. Verify that the "you" account (self dm) is the first item in the list after typing the email address fully

Do we agree 👍 or 👎

[OfstadC]

Payment Summary

• @FitseTLT paid $250 via Upwork
• @DylanDylann paid $250 via Upwork