[HOLD for payment 2024-05-22] [CRITICAL] [VIP-Travel] Workspace - Unable to select country in Company address

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings
3. Click Company address
4. Without entering address first, click Country
5. Select a country

Expected Result:

The country is selected

Actual Result:

The country is not selected. It shows the error "This field is required"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6468902_1714658282392.address.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message appears upon selecting a country

What is the root cause of that problem?

After selecting a country from the country screen, we store this value in route, but fail to update the corresponding field because we don't invoke handleAddressChange.

What changes do you think we should make in order to solve the problem?

Within the WorkspaceProfileAddressPage, we need to incorporate logic that automatically updates both the country and state fields upon selection similar to what we implemented in the AddressPage

const countryFromUrlTemp = route?.params?.country;

    // Check if country is valid
    const countryFromUrl = CONST.ALL_COUNTRIES[countryFromUrlTemp as keyof typeof CONST.ALL_COUNTRIES] ? countryFromUrlTemp : '';
    const stateFromUrl = useGeographicalStateFromRoute();
   
    useEffect(() => {
        if (!countryFromUrl) {
            return;
        }
        handleAddressChange(countryFromUrl, 'country');
    }, [countryFromUrl, handleAddressChange]);

    useEffect(() => {
        if (!stateFromUrl) {
            return;
        }
        handleAddressChange(stateFromUrl, 'state');
    }, [handleAddressChange, stateFromUrl]);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rlinoz]

This is related to a new feature coming from this PR #38381

cc: @smelaa @shubham1206agra

[rlinoz]

Oh this is a new feature and behind a beta, so no need to be a deploy blocker.

[anmurali]

I will post this bug to the PR #38381 and they can look into it.

[smelaa]

Hi! I am Aleksandra Smela from Software Mansion, an expert agency and I am the author of #38381. I can work on this issue.

[cretadn22]

What do you think about my proposal #41505 (comment). Is it a good way to address this issue?

[rlinoz]

Hey @cretadn22 we usually only accept proposals on issues that have the external and help wanted labels. Since this is an issue caused by another PR we try to let the original author to fix it.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [VIP-travel][Fix] Workspace - Unable to select country in Company address #41757

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @smelaa does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@smelaa] Determine if we should create a regression test for this bug.
• [@smelaa] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rlinoz]

@s77rt reviewed the PR

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)
• Contributor: @smelaa is from an agency-contributor and not due payment

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@rlinoz, @anmurali, @s77rt, @smelaa Eep! 4 days overdue now. Issues have feelings too...

[rlinoz]

friendly bump @anmurali

[melvin-bot]

@rlinoz, @anmurali, @s77rt, @smelaa 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[anmurali]

@s77rt - offer is here

[s77rt]

@anmurali Accepted! Thanks!

[melvin-bot]

@rlinoz, @anmurali, @s77rt, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@rlinoz, @anmurali, @s77rt, @smelaa Still overdue 6 days?! Let's take care of this!

[anmurali]

Paid.