-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Jump to last unread chat when opening a report #35011
Comments
Triggered auto assignment to @trjExpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
This PR #28793 specifically makes it scrolled to the bottom, seems like NAB |
I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking. |
HOLD for comment linking: #30269 |
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
No change, still on hold Melv! |
Samesies, Melv! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-30. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
We need one more PR here, so no payment just yet |
Had to deal with a little regression from #52149, last PR should be done Friday or Monday. |
How we looking here? |
FE Draft PR is here #51366 But we will need a backend PR to continue, I will work on that today |
PRs in review |
Last PR Web-E PR was merged today, so we probably can continue with the PR tomorrow @janicduplessis |
@janicduplessis PR is in staging |
PR is WIP, @janicduplessis can you please update the status on when can we expect it to open, TY! |
Working on last adjustments as per #51366 (comment), then will need to do a good round of testing. If all goes well I am expecting it to be ready by start of next week. |
Great stuff! |
Hey @janicduplessis any updates here? |
Sorry about the delay, I didn't end up having much time to work on this this week. It should be ready by early next week :) |
Still working on this, I hit a little issue where for some reason the first unread action is now wrong. It seems to be a regression since it happened after merging main. Trying to pinpoint what caused this. |
Good news, after updating to latest main the regression is gone. PR #51366 is now ready for review and further testing! |
PR is being reviewed, looks like there is one outstanding bug reported here #51366 (comment) |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569
Action Performed:
Expected Result:
The chat report view opens from where the messages are unread and user can scroll down
Actual Result:
The chat report view is scrolled down to the last message and user needs to scroll up to find last read message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.5931.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: