Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Jump to last unread chat when opening a report #35011

Open
6 tasks done
kbecciv opened this issue Jan 23, 2024 · 123 comments
Open
6 tasks done

[$1000] Jump to last unread chat when opening a report #35011

kbecciv opened this issue Jan 23, 2024 · 123 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569

Action Performed:

  1. A is participant of a chat or room
  2. As another user send some good number of messages to chat report, so new messages can be scrolled up and down
  3. As user A, open the chat report

Expected Result:

The chat report view opens from where the messages are unread and user can scroll down

Actual Result:

The chat report view is scrolled down to the last message and user needs to scroll up to find last read message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc144b2f2f5df388
  • Upwork Job ID: 1749920553887232000
  • Last Price Increase: 2024-06-11
  • Automatic offers:
    • ikevin127 | Contributor | 0
    • ishpaul777 | Contributor | 102670752
@kbecciv kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jan 23, 2024
@melvin-bot melvin-bot bot changed the title Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@jeremy-croff
Copy link
Contributor

This PR #28793 specifically makes it scrolled to the bottom, seems like NAB

@trjExpensify
Copy link
Contributor

trjExpensify commented Jan 24, 2024

I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking.

@roryabraham roryabraham changed the title [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message [HOLD #30269] [$500] Chat - When opening a chat with lots of unread messages user needs to scroll up to find last read message Jan 24, 2024
@roryabraham
Copy link
Contributor

HOLD for comment linking: #30269

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Jan 24, 2024
Copy link

melvin-bot bot commented Jan 24, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 24, 2024
@roryabraham roryabraham moved this to HOLD in Comment Linking Jan 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@trjExpensify
Copy link
Contributor

No change, still on hold Melv!

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2024
@trjExpensify
Copy link
Contributor

Samesies, Melv!

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jan 23, 2025
@melvin-bot melvin-bot bot changed the title [$1000] Jump to last unread chat when opening a report [HOLD for payment 2025-01-30] [$1000] Jump to last unread chat when opening a report Jan 23, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 23, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 23, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@rlinoz
Copy link
Contributor

rlinoz commented Jan 23, 2025

We need one more PR here, so no payment just yet

@rlinoz rlinoz changed the title [HOLD for payment 2025-01-30] [$1000] Jump to last unread chat when opening a report [$1000] Jump to last unread chat when opening a report Jan 23, 2025
@rlinoz rlinoz removed the Awaiting Payment Auto-added when associated PR is deployed to production label Jan 23, 2025
@janicduplessis
Copy link
Contributor

Had to deal with a little regression from #52149, last PR should be done Friday or Monday.

@trjExpensify
Copy link
Contributor

How we looking here?

@rlinoz
Copy link
Contributor

rlinoz commented Jan 28, 2025

FE Draft PR is here #51366

But we will need a backend PR to continue, I will work on that today

@rlinoz
Copy link
Contributor

rlinoz commented Jan 31, 2025

PRs in review

@rlinoz
Copy link
Contributor

rlinoz commented Feb 3, 2025

Last PR Web-E PR was merged today, so we probably can continue with the PR tomorrow @janicduplessis

@rlinoz
Copy link
Contributor

rlinoz commented Feb 4, 2025

@janicduplessis PR is in staging

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@ishpaul777
Copy link
Contributor

ishpaul777 commented Feb 6, 2025

PR is WIP, @janicduplessis can you please update the status on when can we expect it to open, TY!

@janicduplessis
Copy link
Contributor

Working on last adjustments as per #51366 (comment), then will need to do a good round of testing. If all goes well I am expecting it to be ready by start of next week.

@trjExpensify
Copy link
Contributor

Great stuff!

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Feb 14, 2025

Hey @janicduplessis any updates here?

@janicduplessis
Copy link
Contributor

Sorry about the delay, I didn't end up having much time to work on this this week. It should be ready by early next week :)

@janicduplessis
Copy link
Contributor

Still working on this, I hit a little issue where for some reason the first unread action is now wrong. It seems to be a regression since it happened after merging main. Trying to pinpoint what caused this.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 22, 2025
@janicduplessis
Copy link
Contributor

Good news, after updating to latest main the regression is gone. PR #51366 is now ready for review and further testing!

@rlinoz
Copy link
Contributor

rlinoz commented Mar 7, 2025

PR is being reviewed, looks like there is one outstanding bug reported here #51366 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: In Progress
Development

No branches or pull requests