[HOLD for payment 2023-12-07] [$500] Group chat - Cursor appears disabled briefly when opening user profile from group member view

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Open a group chat
3. Click on the group chat header
4. Click Members
5. Click on any user

Expected Result:

The cursor will not appear disabled during the transition from group member view to user profile

Actual Result:

The cursor appears disabled briefly when transitioning from group member view to user profile

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270227_1699549723542.20231110_003901.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fd8ea15744b4845
• Upwork Job ID: 1729917653839990784
• Last Price Increase: 2023-11-29

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[adelekennedy]

I can reproduce - this seems small though so I wouldn't make this a deploy blocker

[adelekennedy]

@Li357 I don't see an obvious cause for this when I'm looking through the list here Am I missing an obvious connection here?

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor appears disabled briefly when opening user profile from group member view

What is the root cause of that problem?

In OptionRow, when we click on the row, we will set isDisabled as true

App/src/components/OptionRow.js

Line 166 in 99dd643

setIsDisabled(true);

That makes shouldUseDisabledCursor is true because we removed singleExecution for web in this PR #24482. And then disable cursor displays briefly.

App/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Line 72 in 99dd643

const shouldUseDisabledCursor = useMemo(() => isDisabled && !isExecuting, [isDisabled, isExecuting]);

App/src/hooks/useSingleExecution/index.ts

Line 19 in 99dd643

return {isExecuting: false, singleExecution};

What changes do you think we should make in order to solve the problem?

We should revert the change for useSingleExecution because we are using this in many places and may have other regressions with this change.

What alternative solutions did you explore? (Optional)

We can add the check platform here to not display the cursor disabled on web and desktop.

App/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Line 72 in 99dd643

const shouldUseDisabledCursor = useMemo(() => isDisabled && !isExecuting, [isDisabled, isExecuting]);

[getusha]

We should not revert the change for useSingleExecution it was removed for web because it was causing a lot of bugs due to it's usage of InteractionManager.

[melvin-bot]

@Li357, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Li357, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Li357]

Taking a look now!

[Li357]

I agree we shouldn't do a revert here @dukenv0307. Are there other ways to ensure certain actions that have immediate results to not show as disabled?

[dukenv0307]

@Li357 In OptionRow we can add !props.isDisabled && styles.cursorPointer for style prop of PressableWithFeedback since it will override the cursor style default of BaseGenericPressable.

Or we can create an extra prop like isOnPressing with the default value as false. Update this condition to isDisabled && !isExecuting && !isOnPress.

App/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Line 72 in 99dd643

const shouldUseDisabledCursor = useMemo(() => isDisabled && !isExecuting, [isDisabled, isExecuting]);

And in optionRow, we will create a state called isOnPressing with default as false, in onPress function set it to true

App/src/components/OptionRow.js

Line 166 in 99dd643

setIsDisabled(true);

and reset it as false here

App/src/components/OptionRow.js

Line 175 in 99dd643

result.finally(() => setIsDisabled(props.isDisabled));

And pass this as isOnPressing into PressableWithFeedback

[adelekennedy]

chill Melvin - we're just back from the weekend

[melvin-bot]

@Li357, @adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Contributor role ($500)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent disable cursor when on pressing #31773

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @thesahindia does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

Payouts due:

Contributor: $500 @dukenv0307 (Upwork)
Contributor+: $500 @thesahindia (NewDot)

@dukenv0307 jusy hired you for the job in Upwork - @thesahindia will you check the checklist to see if there are any next steps here?

[melvin-bot]

@Li357, @adelekennedy, @thesahindia, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

@thesahindia bump on the checklist

[adelekennedy]

Also removing Andrew as he's no longer handling issues and re-adding the engineering label

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thesahindia]

@thesahindia will you check the checklist to see if there are any next steps here?

It was a minor regression from #24482. Also we don't need any regression test steps.

[thesahindia]

Payment summary here 😄

[JmillsExpensify]

$500 payment approved for @thesahindia based on this comment.