add std:: to hint::black_box(start) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the review and fix! I completely overlooked this, as my primary development machine is Linux. :) |
|
No problem. An unrelated comment: the exporting example does not compile with edition 2024, and there aren't .gitignores that ignore compilation artifacts. I would create an issue but I am otherwise swamped at the moment. |
|
@DhruvDh I just pushed various fixes to the master branch on GitHub to address Edition 2024 compatibility. Hopefully, these changes resolve all existing issues. The fixes will be included in the next release. Additionally, I've opened ongoing task #7 to track any potential future incompatibility reports. A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added std:: to hint::black_box(start)
I agree to the terms and conditions of the
General License Agreement
and I grant an exclusive license to my changes in this Pull Request to Ilya Lakhin.
Dhruv Dhamani