opening: Do not forget zeroconf channels due to funding timeout
#8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Fixed opening: We no longer forget zeroconf channels in which we own funds due to a confirmation timeout
cdecker
force-pushed
the
20250307-fix-forget-zeroconf
branch
from
f0c516e to
1529f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8147.
We used to forget channels if a) we were the fundee, i.e., had no
stake in the channel, and b) the channel did not confirm in 2016
blocks / 2 weeks.
The first implication is no longer true: with
zeroconfsupport wecan have a stake in a channel, despite not being confirmed yet. With
this assumption no longer true we now need to explicitly check that we
own no funds in the channel on top of checking if we had contributed
to the funding.