Libretro related buildfixes and new presets #3365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake thinks we are crosscompiling (prevents that it pulls in system headers) which makes --check fail. Provide an empty CMAKE_CROSSCOMPILING_EMULATOR to fix this.
Also pass all supported OSX_ARCHITECTURES by default
Simplifies the preset for emscripten a bit and is also needed for iOS and tvOS builds
Small variable fixes in the CMake files
|
warmerhoven on the RetroArch Discord confirmed that it works on iOS and tvOS and shared this screenshot with me:
|
carstene1ns
approved these changes
Mar 11, 2025
|
Minor update: Small change to the logging callback registration because of a bug in RetroArch... (surprise surprise) Was also asked to disable our logfile by default as its redundant (RetroArch / other frontends put it onto their own logfile via that log_cb). Second minor update: The logging API does not automatically insert linebreaks 🤦 |
Otherwise this logs twice (once via RetroArch, once via our logfile)
white-axe
added a commit
to white-axe/mkxp-z
that referenced
this pull request
Mar 12, 2025
See commit d8a6f293e01faac371a8776c1cc65755136febb8 from EasyRPG/Player#3365
fdelapena
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some flaws encountered while updating the libretro core to the latest version on their buildbot.
They offer a recent m1 builder so I was able to test building a libretro core for iOS and tvOS. It works besides some minor issues that are fixed here.
iOS/tvOS presets are not included (more work needed to make them useful)