-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ppcomp, LS.dat & BetterAEP #3363
Draft
florianessl
wants to merge
14
commits into
EasyRPG:master
Choose a base branch
from
florianessl:compat/PPCOMP
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one call in FileFinder; Moved constant for save file count to "Player::Constants::MaxSaveFiles" (Many instances did not check the overridden count)
… Maniac commands into "Game_Interpreter_Shared" (Many other patches implemented something similar before MP)
…mulation support for some external programs can be properly handled.
…n game "Earthcraft")
…euristic check for the "full" version of PowerPatch (unsupported)
…l tools is found in the game directory
…avior. (Could maybe also be used for improving compatibility the Maniac Load command)
…s that also make use of "ppcomp")
…ript handling (Re-enabling it by default, for easier testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Building
FileFinder
Input
Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter
Settings
All about customizable features, storing and applying them
Window/Scenes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the "Compact" version of Cherry's PowerPatch features. This version wasn't really a patch but just an external utility program named "ppcomp.exe" (sometimes renamed to ppcomp.dat or ppcomp.dll) which provided access to some new functions by accessing the memory of the running game process.
Detecting the original PowerPatch to give info about compatibility
This is not the full version of the original "Power Patch", which goes way deeper (including early Lua support) & barely found use in any games. But I also added a small heuristich check to detect the "Full" version & log a warning about limited compatibility:
Supported PPCOMP functions
Not implemented at the moment
For those, I only found instances of "DELETESAVE" & "SIMULATEKEYPRESS" actually being used in some archived games.
-> These are still TODO
Adjustments to Ineluki KeyPatch implementation
BetterAEP patch support
While testing this implementation, it quickly became obvious, that many games that were using ppcomp, also relied on BetterAEP, and some used this patches' special functionality to access the Load Scene or even exiting the game via command. (Even though ppcomp also had these options).
So I added support for this patch as well:
Player.exe --patch-better-aep 3350
So far I've only seen games that use the default var-id of '3350' for this.-> Issue #1182
Some games using ppcomp
Info