Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to std::string_view, liblcf #495 #3360

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate to std::string_view, liblcf #495 #3360

wants to merge 2 commits into from

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 2, 2025

The StartsWith/EndsWith needed manual work, rest was Search/Replace.

@Ghabry Ghabry added this to the 0.8.1 milestone Mar 2, 2025
@github-actions github-actions bot added Android Window/Scenes FileFinder Bitmaps Audio Fonts Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Tests MIDI Messages Settings All about customizable features, storing and applying them Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter Translation labels Mar 2, 2025
@Ghabry Ghabry removed Android Window/Scenes FileFinder Bitmaps Audio Fonts Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Tests MIDI Messages Settings All about customizable features, storing and applying them Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter labels Mar 2, 2025
@Ghabry Ghabry added Has PR Dependencies This PR depends on another PR and removed Translation labels Mar 2, 2025
@Ghabry
Copy link
Member Author

Ghabry commented Mar 10, 2025

@florianessl can you do a compile (a short functionality test) on Windows again?

I already tested config reading/writing with ASAN enabled on Linux so it should work ™️

@florianessl
Copy link
Member

@florianessl can you do a compile (a short functionality test) on Windows again?

I already tested config reading/writing with ASAN enabled on Linux so it should work ™️

Already have!
MSVC build went through without complaint & everything seems to work out fine for my test games here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@florianessl florianessl florianessl approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Has PR Dependencies This PR depends on another PR
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghabry @florianessl @fdelapena