Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[NaughtyDog.com] Update and reactivate ruleset #10383

Merged
merged 5 commits into from
Jun 16, 2017
Merged

[NaughtyDog.com] Update and reactivate ruleset #10383

merged 5 commits into from
Jun 16, 2017

Conversation

Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Jun 14, 2017

@Hainish Hainish added the top-1m label Jun 14, 2017
@cschanaj cschanaj mentioned this pull request Jun 15, 2017
Closed
@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017 •
edited
Loading

Mark as Invalid certificate:

Also:

  • Add target for naughtydog.com and a rule to rewrite it to www

@jeremyn jeremyn self-assigned this Jun 16, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

Thanks, however naughtydog.com should still be in the top comment, otherwise it's not clear why the special rule is needed.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

I wasn't sure how to explain it. Let me know if you would prefer something different.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

I prefer your original text of Different content http/https:.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

I think we should be a bit more verbose for this case because we don't usually add rules when content differs between http and https.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

Okay. I think your description is a little wordy. How about:

	Different HTTP/HTTPS content:
		naughtydog.com (503 status for HTTPS, 301 to www.naughtydog.com for HTTP)

@jeremyn jeremyn merged commit 58ba0ef into EFForg:master Jun 16, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

Thanks, merged.

@jeremyn jeremyn removed their assignment Jun 16, 2017
@Bisaloo Bisaloo deleted the patch-45 branch June 16, 2017 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
top-1m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bisaloo @jeremyn @Hainish