Application.Current removed #71
Merged
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to work with Civils 3D
|
Conflicts need to be resolved here because of the other changes being merged |
reddyashish
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue discussed in the Slack thread where a graph in Dynamo for Civil 3D doesn't run correctly when TuneUp is enabled. I'm not aware of a JIRA ticket for this.
The problem is that
System.Windows.Application.Currentreturnsnullwhen trying to update collections, which stops the UI from updating properly.I've replaced
System.Windows.Application.Current.Dispatcherwith direct access to theCollectionViewSourcedispatcher, this should solve the problem and the UI should still update correctly.@reddyashish
@QilongTang
@dnenov
@Amoursol