Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging back "DYN-8444 Added 2 missing .md files" #15912

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

zeusongit
Copy link
Contributor

Reverts #15906

Seems like this was not causing test failures, putting this back.

@QilongTang
Copy link
Contributor

Thanks, let's hold on this. I have triggered a new build on our pipeline, if daily build is posting, we can merge this in the afternoon

@QilongTang
Copy link
Contributor

master build unblocked, merging

@QilongTang QilongTang merged commit 8d21bb7 into master Mar 7, 2025
22 of 25 checks passed
@QilongTang QilongTang deleted the revert-15906-revert-15901-master branch March 7, 2025 18:10
@@ -1,7 +1,6 @@
<!--- Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BySphereBestFit --->
<!--- RUAGD4YGKJ6XHPIKDL7GZX63CDAFMI6KUSR6XMXEBGJJOATEI5IA --->
## BySphereBestFit - Documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad here, @zeusongit I dont think we want to remove the comments since they indicate the original file name

Copy link
Contributor

@QilongTang QilongTang Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found this out when looking at the corresponding localization PR, because this has the downstream impact of removing such mapping for all the localization markdown files as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so do we want to retain the first 2 lines here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @zeusongit Please, this is so that we can locate and update easier for these md files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants