Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group/Annotation lookup performance #15855

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bendikberg
Copy link
Contributor

Purpose

This PR replaces the node hashset in annotations (groups) with a dictionary. The reason for this is to enable looking up group nodes by guid. Currently this is mostly done by searching for guids using linq queries, which means the node hashset serves no purpose.

Performance

All node-by-guid queries on groups will be sped up (unless the number of nodes in the group is very very small), this scales much better to large groups.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

@mjkkirschner

FYIs

@dimven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants