Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6728 feature flags should be controlled by no network mode when creating a dynamo model directly. #14975

Merged
merged 6 commits into from
Feb 27, 2024
Merged

DYN-6728 feature flags should be controlled by no network mode when creating a dynamo model directly. #14975

merged 6 commits into from
Feb 27, 2024

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Feb 26, 2024 •
edited
Loading

Purpose

DYN-6728

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

fixed a bug where no network mode might not control feature flags retrieval for some dynamo integrations.

Reviewers

@mjkkirschner mjkkirschner added this to the 3.0.4 milestone Feb 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

aparajit-pratap
aparajit-pratap reviewed Feb 26, 2024
View reviewed changes
test/DynamoCoreTests/Logging/AnalyticsServiceTest.cs

dynamoCLI?.Kill();
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mjkkirschner mjkkirschner merged commit 664a2a1 into DynamoDS:master Feb 27, 2024
21 of 22 checks passed
@mjkkirschner mjkkirschner deleted the nonetworkff branch February 27, 2024 13:04
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Feb 27, 2024
@mjkkirschner
DYN-6728 feature flags should be controlled by no network mode when c…
ebeb728 
…reating a dynamo model directly. (DynamoDS#14975)

* check network mode

* align disable and networkmode

* add small tests

* remove todo

* review comments

* another test
@mjkkirschner mjkkirschner mentioned this pull request Feb 27, 2024
Merged
mjkkirschner added a commit that referenced this pull request Feb 27, 2024
@mjkkirschner
DYN-6728 feature flags should be controlled by no network mode when c…
4c94153 
…reating a dynamo model directly. (#14975) (#14980)

* check network mode

* align disable and networkmode

* add small tests

* remove todo

* review comments

* another test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

@pinzart90 pinzart90 Awaiting requested review from pinzart90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkkirschner @aparajit-pratap