Fix missing libjpeg in ARM MacOS and set MacOS libraries in CMakeLists.txt #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyLeite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the build process for MacOS by setting the library paths in the CMakeLists.txt file, essentially removing the need for
macos-cmake.shto exist.It also fixes #471 and #654, which are related to
libjpegbeing shipped as a keg on ARM MacOS machines, making it so it's not symlinked to homebrew's prefix. This is due to it conflicting withlibjpeg-turbo, which is (as far as I can tell) faster and ABI compatible, so I took the liberty of replacing it entirely. If this is undesirable, let me know and I can instead have cmake link with the correct path forlibjpegas I did withlibarchive.