reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085

reviewdog exited with status code: 1

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[clippy] reported by reviewdog 🐶 warning: unused variable: `tick` --> kson/src/graph.rs:83:23 | 83 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` | = note: `#[warn(unused_variables)]` on by default Raw Output: kson/src/graph.rs:83:23:w:warning: unused variable: `tick` --> kson/src/graph.rs:83:23 | 83 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` | = note: `#[warn(unused_variables)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: unused variable: `tick` --> kson/src/graph.rs:154:23 | 154 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` Raw Output: kson/src/graph.rs:154:23:w:warning: unused variable: `tick` --> kson/src/graph.rs:154:23 | 154 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` __END__

[clippy] reported by reviewdog 🐶 warning: unused variable: `tick` --> kson/src/graph.rs:170:23 | 170 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` Raw Output: kson/src/graph.rs:170:23:w:warning: unused variable: `tick` --> kson/src/graph.rs:170:23 | 170 | fn wide_at(&self, tick: f64) -> u32 { | ^^^^ help: if this is intentional, prefix it with an underscore: `_tick` __END__

[clippy] reported by reviewdog 🐶 warning: single-character string constant used as pattern --> kson/src/ksh.rs:129:25 | 129 | let mut v = v.split(";"); | ^^^ help: consider using a `char`: `';'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default Raw Output: kson/src/ksh.rs:129:25:w:warning: single-character string constant used as pattern --> kson/src/ksh.rs:129:25 | 129 | let mut v = v.split(";"); | ^^^ help: consider using a `char`: `';'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: comparison to empty slice --> kson/src/ksh.rs:280:36 | 280 | ... if legacy_string != "" { | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!legacy_string.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty = note: `#[warn(clippy::comparison_to_empty)]` on by default Raw Output: kson/src/ksh.rs:280:36:w:warning: comparison to empty slice --> kson/src/ksh.rs:280:36 | 280 | ... if legacy_string != "" { | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!legacy_string.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty = note: `#[warn(clippy::comparison_to_empty)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: use of `char::is_digit` with literal radix of 10 --> kson/src/ksh.rs:800:35 | 800 | if p1.chars().all(|x| x.is_digit(10)) { | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default Raw Output: kson/src/ksh.rs:800:35:w:warning: use of `char::is_digit` with literal radix of 10 --> kson/src/ksh.rs:800:35 | 800 | if p1.chars().all(|x| x.is_digit(10)) { | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: use of `char::is_digit` with literal radix of 10 --> kson/src/ksh.rs:814:35 | 814 | if p1.chars().all(|x| x.is_digit(10)) { | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix Raw Output: kson/src/ksh.rs:814:35:w:warning: use of `char::is_digit` with literal radix of 10 --> kson/src/ksh.rs:814:35 | 814 | if p1.chars().all(|x| x.is_digit(10)) { | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix __END__

[clippy] reported by reviewdog 🐶 warning: accessing first element with `self.beat.time_sig.get(0)` --> kson/src/lib.rs:1012:34 | 1012 | let mut prev_sig = match self.beat.time_sig.get(0) { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.beat.time_sig.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default Raw Output: kson/src/lib.rs:1012:34:w:warning: accessing first element with `self.beat.time_sig.get(0)` --> kson/src/lib.rs:1012:34 | 1012 | let mut prev_sig = match self.beat.time_sig.get(0) { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.beat.time_sig.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: unused import: `Sample` --> kson-rodio-sources/src/biquad.rs:6:13 | 6 | use rodio::{Sample, Source}; | ^^^^^^ | = note: `#[warn(unused_imports)]` on by default Raw Output: kson-rodio-sources/src/biquad.rs:6:13:w:warning: unused import: `Sample` --> kson-rodio-sources/src/biquad.rs:6:13 | 6 | use rodio::{Sample, Source}; | ^^^^^^ | = note: `#[warn(unused_imports)]` on by default __END__