Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair is_ci handling, sudo was erasing the variables #274

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

sudo was erasing the variables which is_ci checks for CI. Instead of preserving the entire list, we opt to run it once and set a nix-installer specific env for CI and or with is_ci's result later.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear requested a review from cole-h February 24, 2023 21:54
@Hoverbear Hoverbear self-assigned this Feb 24, 2023
@Hoverbear Hoverbear marked this pull request as ready for review February 24, 2023 21:54
@Hoverbear Hoverbear added this to the v0.3.1 milestone Feb 24, 2023
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants