Refactor diagnostics into Feedback, replace ours with detsys-ids-client #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
added
the
upload to s3
This replaces the Diagnosticdata and pervasive feature-checking with a trait with a null implementation by default. The null implementation is more ergonomic for a couple reasons 1. needing to feature-check everywhere made it harder to write correct code for both cases. 2. Option's can't be map()'d and other combinators with async closures. This also introduces the possibility of feature flagging behavior. The feature flags come from the `feedback` provider, and the null version has none. If you specify a `--diagnostic-endpoint` of `file://....` the diagnostics are sent to that path. The format of this output has changed. With a file endpoint, you can set the `DETSYS_IDS_CHECKIN_FILE` environment variable to a file to provide the feature flag data. If you specify a `--diagnostic-endpoint` of an HTTP(S) address, the specific path is truncated and replaced with `/check-in` and `/events/batch`. Note the default endpoint is now set to None, which means use the default backend. This is because the specific host used for diagnostics is identified using an SRV record for failover and traffic shaping purposes. Overall, this change replaces the initial and ad-hoc IDS client with a crate dedicated to the task.
cole-h
reviewed
Feb 7, 2025
cole-h
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the Diagnosticdata and pervasive feature-checking with a trait with a null implementation by default.
The null implementation is more ergonomic for a couple reasons
This also introduces the possibility of feature flagging behavior. The feature flags come from the
feedbackprovider, and the null version has none.If you specify a
--diagnostic-endpointoffile://....the diagnostics are sent to that path. The format of this output has changed.With a file endpoint, you can set the
DETSYS_IDS_CHECKIN_FILEenvironment variable to a file to provide the feature flag data.If you specify a
--diagnostic-endpointof an HTTP(S) address, the specific path is truncated and replaced with/check-inand/events/batch.Note the default endpoint is now set to None, which means use the default backend. This is because the specific host used for diagnostics is identified using an SRV record for failover and traffic shaping purposes.
Overall, this change replaces the initial and ad-hoc IDS client with a crate dedicated to the task.
Description
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: