[models:law] Fixed misused async behavior when voting. Closes #394. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still working here, don't merge! |
…ng buttons. Closes #394.
|
Ready to review & merge. Please comment any issue. |
| this.votes.push(vote); | ||
| // Add citizen as participant | ||
| this.addParticipant(citizen); | ||
| this.save(cb); |
There was a problem hiding this comment.
You're missing the if (cb) here
|
Done. Check this out now. |
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| .proposal-options | |||
| .vote-box | |||
| div#voting-error.alert.alert-warning.hide #{t('Connection error when voting')}. | |||
There was a problem hiding this comment.
@jfresco please use i18n keys in the canonical format. In this case I guess proposal-options.error.voting would do
|
Also, please add i18n keys for all languages. Google translate will do. |
Conflicts: lib/models/law.js lib/proposal-options/proposal-options.js
|
@jfresco I updated your code to the view refactor approach. I tried it out and seems to be working just fine, but please double-check with your concurrent/error test dataset so we can be sure I introduced no bug and we can go ahead with the merge. |
jfresco
added a commit
that referenced
this pull request
Dec 11, 2014
[models:law] Fixed misused async behavior when voting. Closes #394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
unvoteis async, but it was being used in a sync way. This may have caused race conditions and led to this odd behavior.