Skip to content
This repository was archived by the owner on Apr 30, 2019. It is now read-only.

tsd link doesn't support npm scoped packages #194

Closed
jjrv opened this issue Jul 30, 2015 · 1 comment
Closed

tsd link doesn't support npm scoped packages #194

jjrv opened this issue Jul 30, 2015 · 1 comment

Comments

@jjrv
Copy link
Contributor

jjrv commented Jul 30, 2015

When looking for Node.js packages, tsd link scans node_modules/*/packages.json (see code) but the glob should also include node_modules/@*/*/packages.json because scoped packages are installed in subfolders named after the scope (always prefixed with @).

If I change the glob pattern in the linked code to var pattern = '{*,@*/*}/' + type.infoJson; then linking works but repeated linking keeps re-discovering the same packages and appending duplicates to tsd.d.ts so other changes are still needed somewhere. Pull request #195 seems to fix the problem.

blakeembrey added a commit that referenced this issue Aug 2, 2015
Fix #194, support tsd link for npm scoped packages.
@blakeembrey
Copy link
Member

Thanks for the PR. I just merged it and will do a release for you. Since I don't use this feature much yet, you'll have to let me know if you have more issues. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants