tsd reinstall does not remove stale typings

[alexeagle]

I updated my tsd.json to remove touch-events.d.ts, because the new typescript 1.5 beta includes those natively in the lib.d.ts, and the compilation fails due to duplicate type definitions.

I run tsd reinstall, and the touch-events.d.ts is left in the typings folder. Based on the documentation for reinstall:
Reset the definitions to the commits listed in tsd.json
I would expect any typings not in tsd.json to be removed.

The current workaround is everyone on the team needs to remove the typings folder whenever something is removed from tsd.json.

[blakeembrey]

@alexeagle You're right, I'd expect this too. I plan on doing a lot of refactoring on this project and that's one of the first things being fixed in #150. Thanks for the report 👍

[alexeagle]

Nice, I noticed your roadmap this morning, and glad to see you are laying plans for those fixes. Soon we will figure out the right way to distribute the type definitions for Angular, likely with tsd.

[Diullei]

I think this should be resolved by adding an uninstall command. With this I'll ensure that any of my own typing (if exists) in the same directory (typings) will not be removed.

What do you think?

[alexeagle]

I don't think that solves our problem: we check in a tsd.json as a means to
keep the typings directories on the machines of all our team members in
sync. What command would we put in 'npm install' that would cause all the
typings to be synced? tsd uninstall --all && tsd reinstall?

On Sat, Jun 6, 2015 at 10:12 PM, Diullei Gomes [email protected]
wrote:

I think this should be resolved by adding an uninstall command. With this
I'll ensure that any of my own typing (if exists) in the same directory (
typings) will not be removed.

What do you think?

—
Reply to this email directly or view it on GitHub
#151 (comment)
.

[Diullei]

Ok @alexeagle, I Got your point. In this case the reinstall command must remove the typings not referenced by tsd.json

[jimlloyd]

@alexeagle see the discussion in #179. Would do you think of tsd reinstall --clean as a solution for your problem?

[alexeagle]

@jimlloyd thanks for the notification, I commented over there.

[Diullei]

Hi @alexeagle! I published a new version ([email protected]) to fix the bug that you reported here #184 (comment)

Could you verify if it is ok now?

To install:

npm install [email protected]

[alexeagle]

yes, it looks good now, I sent a PR to use it in Angular:
angular/angular#3940

Thanks!

On Tue, Sep 1, 2015 at 7:18 AM Diullei Gomes [email protected]
wrote:

Hi @alexeagle https://github.com/alexeagle! I published a new version (
[email protected]) to fix the bug that you reported here #184 (comment)
#184 (comment)

Could you verify if it is ok now?

To install:

npm install [email protected]

—
Reply to this email directly or view it on GitHub
#151 (comment)
.

[Diullei]

Nice! I'm glad to help you with this issue!

I'll close this issue for now, feel free to reopen it if you got another problem.

Thanks!