Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid proliferation of constants and ensure they're initialised #443

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Avoid proliferation of constants and ensure they're initialised #443

merged 1 commit into from
Jul 10, 2018

Conversation

ColinHebert
Copy link
Contributor

@ColinHebert ColinHebert commented Jun 26, 2018 •
edited
Loading

Fixes #442

@irabinovitch irabinovitch requested a review from truthbk June 26, 2018 05:07
@truthbk truthbk self-assigned this Jul 5, 2018
truthbk
truthbk approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @ColinHebert 🙇

@truthbk
Copy link
Member

truthbk commented Jul 10, 2018

The CI issue has been fixed on master so we can just merge despite the known errored test runs.

@truthbk truthbk merged commit ba0f729 into DataDog:master Jul 10, 2018
@truthbk truthbk added this to the 2.3.0 milestone Jul 11, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
@ColinHebert @truthbk
Avoid proliferation of constants and ensure they're initialised (Data…
1d34131 
…Dog#443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees

@truthbk truthbk

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinHebert @truthbk