Make tags there own resourced, allow hiera created integrations, setup check_feq #261
Conversation
|
@truthbk This is the new version. It should be fine. Please keep me posted. I dont want this to be like the integration PR where it sat for like 6 months. There are some usefull features in this PR. That I would think the community would like. The ability to define a tag as a resource makes it a lot more flexable for us. |
cwood
changed the title
truthbk
force-pushed
the
cwood/bitbucket-changes-pr
branch
2 times, most recently
from
ee0ab3d to
dd043c1
Compare
|
Thanks for taking over this. Hopefully the community finds this useful. |
truthbk
force-pushed
the
cwood/bitbucket-changes-pr
branch
from
7cdf9a7 to
4e766bf
Compare
|
@cwood to the contrary, thank you for your constant contributions! 🙇 |
|
Cool, I think we're green now. I'll have to run a few tests... I'm hoping we can merge this before Friday, and if no backward incompatibilities are found we'll have this in the next module release. @cwood heads-up on a force push to your branch. |
There is one already but only allows one since its a class we can not do a bunch of integrations and replace the class with this. Also this will allow you to write ruby, or hiera and put it in the config you need.
…e relevant fragments.
truthbk
force-pushed
the
cwood/bitbucket-changes-pr
branch
from
009f344 to
29d0847
Compare
|
Left a comment about |
|
Thanks @sjenriquez, great catch on that one. Will merge if tests are green. |
manifests/init.pp
Outdated
| @@ -52,6 +52,8 @@ | |||
| # $statsd_forward_port | |||
| # Set the value of the statsd_forward_port varable. Used to forward all | |||
| # statsd metrics to another host. | |||
| # $check_freq | |||
| # Sets how often checks should be run. By default, set to 15s | |||
There was a problem hiding this comment.
While this is valid, we don't recommend changing the check_freq. I think we should remove this parameter.
There was a problem hiding this comment.
This will break us if we dont have that. If its exposed by the dd-agent and documented why cant it be set by the module?
manifests/init.pp
Outdated
| @@ -200,6 +204,7 @@ | |||
| $statsd_forward_host = '', | |||
| $statsd_forward_port = '', | |||
| $statsd_histogram_percentiles = '0.95', | |||
| $check_freq = '', | |||
templates/datadog_footer.conf.erb
Outdated
| check_freq: <%= @check_freq %> | ||
| <% end -%> | ||
|
|
||
|
|
There was a problem hiding this comment.
See comment above regarding check_freq
|
I put in the comment that we do use check_freq so that isnt really great for us. Ill have to double check what we set it too. But id rather keep it then remove it. |
|
@cwood going to merge this, as it's a pain to rebase, and looks pretty much ready to go. Can we revisit |
|
Its no worries thanks for working on this. Glad this got merged in :) |
|
This broke the |
…p check_feq (DataDog#261) * Make a generic define for creating modules There is one already but only allows one since its a class we can not do a bunch of integrations and replace the class with this. Also this will allow you to write ruby, or hiera and put it in the config you need. * Remove unused template * Add support for init_config if passed * Update to remove the empty string. * Adding logic to handle tags as arrays. * Allow support for integrations from hiera * Fix some typos * Add check_freq setting * Allow the ability to purge unsued configs * Notify the service * Setup a spec test * Set recurse to true * Set force to true if purge is true * Allow tags to be there own define. * Fix name * Allow looking up facts to tags * Fix unless issue * If a array call itself and add the fragment * Check if is_array * Remove map and use map() * Migrate tags to its own array * Prefix everything with the tag * Make tags its own thing * Only run if not a tag * Add a begining new line * Only add if we have a value * [service_discovery][dogstatsd] adding relevant SD and dogstatsd to the relevant fragments. * [apm] adding apm tests. * [datadog-agent][spec] check fragment contents instead. * [spec] fix ports as integers for new concat templates. * [templates] removing global template, we now use concat templates. * [main] dogstatsd should also allow string and integer ports - like other params. * [init] remove check_freq, undocumented.
These are a bunch of changes we have made to the puppet module.