Skip to content
This repository was archived by the owner on Jan 23, 2020. It is now read-only.

single tag global conf #182

Merged
merged 6 commits into from
Dec 16, 2019
Merged

single tag global conf #182

merged 6 commits into from
Dec 16, 2019

Conversation

gzussa
Copy link
Contributor

@gzussa gzussa commented Dec 12, 2019

@gzussa gzussa requested review from a team as code owners December 12, 2019 15:37
@gzussa gzussa changed the title Gzu/single tag global conf single tag global conf Dec 12, 2019
nmuesch
nmuesch reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Left a minor doc comment.

nmuesch
nmuesch approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, assuming manual testing and things went well :)

cswatt
cswatt approved these changes Dec 16, 2019
View reviewed changes
Copy link

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved wrt documentation

@gzussa gzussa merged commit 0bb7413 into master Dec 16, 2019
@gzussa gzussa deleted the gzu/single_tag_global_conf branch December 16, 2019 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cswatt cswatt cswatt approved these changes

@nmuesch nmuesch nmuesch approved these changes

@zippolyte zippolyte zippolyte approved these changes

Assignees
No one assigned
Labels
changelog/Fixed documentation kind/feature-request severity/normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Append the default parameter "Add tags from file in workspace" in general plugin configuration
4 participants
@gzussa @cswatt @nmuesch @zippolyte