Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SSL parameters #12743

Merged
merged 7 commits into from
Aug 15, 2022
Merged

Rename SSL parameters #12743

merged 7 commits into from
Aug 15, 2022

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Aug 12, 2022

What does this PR do?

Change the variable from camelCase to snake_case to keep consistency with other params

Motivation

QA for #12541

Other

In the future we should deprecate a lot of the ssl_* params that we still have in the check. The newly added ones tls_* are their replacement and seems like the ssl_* ones are deprecated:

https://pymongo.readthedocs.io/en/stable/api/pymongo/mongo_client.html#pymongo.mongo_client.MongoClient

version 3.9 (3.11.4+ is shipped starting Agent 7.30):
ssl_cert_reqs was deprecated in favor of tls_allow_invalid_certificates.
ssl_match_hostname was deprecated in favor of tls_allow_invalid_hostnames.
ssl_ca_certs was deprecated in favor of tls_ca_file.
ssl_certfile was deprecated in favor of tls_certificate_key_file.
ssl_crlfile was deprecated in favor of tlsCRLFile.
ssl_pem_passphrase was deprecated in favor of tlsCertificateKeyFilePassword.

version 3.12(3.12.3+ is shipped with agent 7.36):
ssl_certfile and ssl_keyfile were deprecated in favor of tls_certificate_key_file.

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #12743 (840ae88) into master (a3d3bde) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
mongo 95.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek changed the title Rename parameters in mongo check Rename SSL parameters Aug 15, 2022
@ofek ofek merged commit 75ad468 into master Aug 15, 2022
@ofek ofek deleted the sy/mongo-params branch August 15, 2022 15:50
ofek pushed a commit that referenced this pull request Aug 15, 2022
* add active-tasks and timeout beans

* re-order beans

* metadata and tests

* fix metadata.csv

* variable renaming

* clean up

* remove stuff from another branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants