Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix milestone job #4470

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix milestone job #4470

merged 1 commit into from
Mar 6, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?
The job is broken because the previous change https://github.com/DataDog/dd-trace-rb/pull/4457/files#diff-aef600c7d513d344ec6a22c6780e7555f28e946db6685f4c2151500961b2780b

Change log entry
None.

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 6, 2025
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 6, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review March 6, 2025 21:44
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner March 6, 2025 21:44
@TonyCTHsu TonyCTHsu enabled auto-merge March 6, 2025 21:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (fb1935b) to head (8389619).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   97.70%   97.68%   -0.02%     
==========================================
  Files        1376     1376              
  Lines       83825    83825              
  Branches     4251     4251              
==========================================
- Hits        81899    81887      -12     
- Misses       1926     1938      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: tonycthsu/fix-milestone-job
Commit report: 8389619
Test service: dd-trace-rb

✅ 0 Failed, 20623 Passed, 1370 Skipped, 3m 15.71s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-06 22:07:05

Comparing candidate commit 8389619 in PR branch tonycthsu/fix-milestone-job with baseline commit fb1935b in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - 100 span trace - no writer

  • 🟥 throughput [-18.469op/s; -17.889op/s] or [-5.297%; -5.131%]

@TonyCTHsu TonyCTHsu merged commit 4eb6123 into master Mar 6, 2025
482 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-milestone-job branch March 6, 2025 22:09
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants