-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AppSec ActiveRecord instrumentation for Rails 4 and ruby < 2.7 #4437
Fix AppSec ActiveRecord instrumentation for Rails 4 and ruby < 2.7 #4437
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20781 Passed, 1379 Skipped, 3m 14.63s Total Time |
BenchmarksBenchmark execution time: 2025-02-27 09:56:15 Comparing candidate commit 82cb155 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
scenario:tracing - Tracing.log_correlation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4437 +/- ##
==========================================
- Coverage 97.71% 97.68% -0.03%
==========================================
Files 1374 1374
Lines 83755 83806 +51
Branches 4236 4249 +13
==========================================
+ Hits 81841 81870 +29
- Misses 1914 1936 +22 ☔ View full report in Codecov by Sentry. |
aa39abc
to
82cb155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼 Well done
What does this PR do?
This PR fixes AppSec ActiveRecord instrumentation for Rails version 4.
Motivation:
AppSec ActiveRecord instrumentation raised
ArgumentError
with Rails 4 and Ruby < 2.7.The reason for this was the fact that Ruby versions older than 2.7 passed empty hash as a positional argument for empty hash splat.
https://rubyreferences.github.io/rubychanges/2.7.html#keyword-argument-related-changes
Change log entry
Yes. AppSec: Fix ActiveRecord instrumentation for Rails 4 and ruby < 2.7
Additional Notes:
None
How to test the change?
CI and manual testing.