-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test over multiple ActiveSupport versions (with Appraisal) #289
Conversation
7124500
to
3cc31e8
Compare
At the end, I went to add more tests (not changing the current tests) and limit to Ruby 3.0+ due to too many incompatibilities with dependencies. With this addition, we will have insurance that old versions are working once ActiveSupport 7.1 is added. |
@Floppy I know the project was not using Appraisal and that add one more thing to think and know. I would be happy to help on spreading the knowledge even it is the first for myself too to use Appraisal. If there is a need to a maintainer to maintain the code (no feature implementation), I would be happy to help. I would like to update the code to comply to StandardRb (remove the exceptions) and rely on the CSV gem version instead of the Ruby version (with the current PR that test against multiple Ruby version, it is safer to do that change). |
Sorry for the delay! This is super cool work, thank you. I've not used Appraisal before, but testing across multiple gem dependency versions is fantastic, so I'm happy for it to be added. Only question is, do we need to include the lockfiles in the repo, or should they (can they) be .gitignored? |
Good question. |
I think unless it's important for Appraisal to work properly, we should probably leave them out. 👍🏻 |
Ah, sorry, I was unclear. I think the gemfiles themselves should be there, but the lockfiles can be left out - looks like that's what others are doing. Can you remove those and add to .gitignore? |
e6853ac
to
2e8a1c7
Compare
Test ActiveSupport from 5.2 to 7.0 on Ruby 3.0 to 3.3. Ruby 2.x has too compatibility issues with recent versions of dependencies.
@Floppy Thank you for the explanation, I totally misread your message. Sorry about that. I removed the lockfiles. I excluded Ruby 2.5 and 2.6 from ActiveSupport 7.0 due to incompatibility issue from the gem: |
exclude: | ||
- ruby-version: '2.5' | ||
activesupport-version: activesupport_7.0 | ||
- ruby-version: '2.6' | ||
activesupport-version: activesupport_7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test ActiveSupport from 5.2 to 7.0 over ruby version 3.0 to 3.3.
It ensure that all versions are care of.
The matrix of tests is:
ActiveSupport
5.2
: Ruby2.5
,2.6
,2.7
,3.0
,3.1
,3.2
and3.3
ActiveSupport
6.0
: Ruby2.5
,2.6
,2.7
,3.0
,3.1
,3.2
and3.3
ActiveSupport
6.1
: Ruby2.5
,2.6
,2.7
,3.0
,3.1
,3.2
and3.3
ActiveSupport
7.0
: Ruby2.7
,3.0
,3.1
,3.2
and3.3
(Ruby 2.7+ required)With the current limitation of ActiveSupport 7.0 max (from #279), when ActiveSupport 7.1 is supported we will have tests for 7.0 and below.