Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarshalSolidity: wrong serialisation of Bsb22Commitments openings #761

Closed
ThomasPiellard opened this issue Jul 5, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working zk-evm

Comments

@ThomasPiellard
Copy link
Collaborator

if len(proof.Bsb22Commitments) > 0 {
		tmp32 = proof.BatchedProof.ClaimedValues[7].Bytes()
		res = append(res, tmp32[:]...)

		for _, bc := range proof.Bsb22Commitments {
			tmp64 = bc.RawBytes()
			res = append(res, tmp64[:]...)
		}
	}

Only the proof.BatchedProof.ClaimedValues[7] value is serialised while it should be proof.BatchedProof.ClaimedValues[7:7+nb_bsb22_commitments]

@ThomasPiellard ThomasPiellard added bug Something isn't working zk-evm labels Jul 5, 2023
@ThomasPiellard ThomasPiellard self-assigned this Jul 5, 2023
ThomasPiellard added a commit that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working zk-evm
Projects
None yet
Development

No branches or pull requests

1 participant