Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add encoding argument (default to utf-8) to to_dict function #43

Merged
merged 2 commits into from
Dec 22, 2022
Merged

add encoding argument (default to utf-8) to to_dict function #43

merged 2 commits into from
Dec 22, 2022

Conversation

665465
Copy link

@665465 665465 commented Dec 19, 2022 •
edited
Loading

fixed: #39

@665465 665465 mentioned this pull request Dec 19, 2022
Closed
Colin-b
Colin-b approved these changes Dec 22, 2022
View reviewed changes
Copy link
Owner

@Colin-b Colin-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the new parameter and add a test case ensuring that we always use UTF-8. Parameter to be introduced if a specific use case emerge

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Colin-b Colin-b merged commit 86f1c0c into Colin-b:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Colin-b Colin-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_dict does not allow to provide a custom encoding
2 participants
@665465 @Colin-b