Add pre-integrate hook #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
Dec 18, 2020
lib/cocoapods-core/podfile/dsl.rb
Outdated
| # [`Pod::Installer`](http://rubydoc.info/gems/cocoapods/Pod/Installer/) | ||
| # as its only argument. | ||
| # | ||
| # @example Customising the dependencies before integration |
There was a problem hiding this comment.
followed the other definitions in this file.. I've updated them all to use proper americanism.
There was a problem hiding this comment.
@dcvz thanks, I hadn't noticed the rest of these entries. I havent written the whole code here to be aware of this.
dnkoutso
reviewed
Dec 18, 2020
lib/cocoapods-core/podfile/dsl.rb
Outdated
| # to disk. | ||
| # | ||
| # It receives the | ||
| # [`Pod::Installer`](http://rubydoc.info/gems/cocoapods/Pod/Installer/) |
There was a problem hiding this comment.
I dont think classes are linked like this style.
There was a problem hiding this comment.
I've followed the format of the other def's in this file.. should I change them all?
|
@dcvz can you please rebase this PR to latest master? |
dnkoutso
reviewed
Dec 31, 2020
lib/cocoapods-core/podfile.rb
Outdated
| # @param [Pod::Installer] installer | ||
| # the installer that is performing the installation. | ||
| # | ||
| # @return [Bool] whether a pre install callback was specified and it was |
There was a problem hiding this comment.
this should be "pre integrate callback"
|
I've implemented the requested changes @dnkoutso and rebased against the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a
pre-integratehook that will allow plugins to make changes to downloaded pods before the integration into projects.This is useful for a plugin such as a
cocoapods-patchthat allows users to create patch files for pod dependencies.. whose changes might include a file deletion (which needs to happen before the integration to not cause problems).CocoaPods PR: CocoaPods/CocoaPods#9935