Fix JSON deserialization for test specs #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
fix_json_support
branch
2 times, most recently
from
41395e2 to
7ca1336
Compare
segiddins
approved these changes
Aug 3, 2017
| results.add_error('test_type', "The test type `#{t}` is not supported. " \ | ||
| supported_test_types = Specification::DSL::SUPPORTED_TEST_TYPES.map(&:to_s) | ||
| unless supported_test_types.include?(t.to_s) | ||
| results.add_error('test_type', "The test type `#{t.to_s}` is not supported. " \ |
There was a problem hiding this comment.
the to_s in a string interpolation segment is implied
dnkoutso
force-pushed
the
fix_json_support
branch
from
7ca1336 to
3f110ff
Compare
endocrimes
pushed a commit
that referenced
this pull request
Aug 6, 2017
Fix JSON deserialization for test specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.