Update DSL for spec.source
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Jun 19, 2017
|
Heh, its funny cause we have plenty of development pods..that we never publish. Wonder if this should actually become supported...but I wont object further :) |
|
@dnkoutso you know my feeling on this subject 🙃 |
endocrimes
approved these changes
Jun 19, 2017
|
Shall I put this under "## 1.3.0.beta.1" section? |
|
@maxkomarychev no beta.1 shipped so place it as a bug fix above it. Remove the |
|
@maxkomarychev can you rebase please? |
Current implementation of downloader does not provide strategy for `:path`.
maxkomarychev
force-pushed
the
feature/cleanup-source-dsl
branch
from
df90246 to
76054e7
Compare
|
@dnkoutso done! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to current implementation of downloader https://github.com/CocoaPods/cocoapods-downloader/blob/978dfcd59e028db875cd4bb191ebbf3195b6fc26/lib/cocoapods-downloader.rb#L21-L29 the
:pathkey is not supported forspec.sourceand the doc available here is misleading.Couple of related issues:
CocoaPods/CocoaPods#4937
CocoaPods/cocoapods-packager#32
// disclaimer
I quite far away from ruby development and mostly do mobile. Please let me know if there any more places where this should be cleaned up.
Thanks for great tool.