[JSON] Generated podspec should have a newline at the end of the file

[segiddins]

No description provided.

[cjwirth]

Are you talking about when running pod ipc spec?
Now it just writes the output of to_json to stdout, which seems pretty clean to me.

Why would you want a newline at the end? It seems like none of the specs in https://github.com/CocoaPods/Specs have newlines at the end...

[fabiopelosin]

ping

[kylef]

The spec's generated by trunk are not using Core to save the JSON, but instead pretty printing the JSON and adding a newline to those specs would have to be done in trunk.cocoapods.org.

[fabiopelosin]

Closing until @segiddins provides evidence that the change is needed.

[segiddins]

It's not needed, but I feel like files should always have a newline at the end.

[fabiopelosin]

@segiddins Why is it personal preference or there is a more definite reason that we can discuss?

[orta]

It's a UNIX standard, http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline - we should probably do it because of git anyway.

[fabiopelosin]

Good point.

[kylef]

@fabiopelosin ec7a76e Only affects pod ipc but not the specs generated by pod trunk push is that intentional?

[fabiopelosin]

Why not? Isn't push using this method? https://github.com/CocoaPods/cocoapods-trunk/blob/master/lib/pod/command/trunk.rb#L290

[kylef]

@fabiopelosin Yes, but it's not saved to the repository as that. It's prettified using https://github.com/CocoaPods/trunk.cocoapods.org/blob/master/app/controllers/api/pods_controller.rb#L76 which won't keep the \n.

[fabiopelosin]

Oh I see what you mean... Good call: CocoaPods/trunk.cocoapods.org#103

[kylef]

Great, I wasn't sure on the scope of this issue, it was never really clear. Great stuff 👍.