Spark: Fix ArrayIndexOutOfBoundsException #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Jul 12, 2023
|
Thanks, manually tested by disabling agg push down. class ClickHouseScanBuilder
...
override def pushAggregation(aggregation: Aggregation): Boolean = {
+ return false
...It failed before this patch and success after this patch. The future work is introducing a configuration to allow disabling agg pushdown, then we can cover it in CI. |
pan3793
pushed a commit
that referenced
this pull request
Jul 12, 2023
… and agg pushdown does not take effects (#256) Co-authored-by: eye <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Jul 14, 2023
… and agg pushdown does not take effects (#256) Co-authored-by: eye <[email protected]>
Yxang
pushed a commit
to Yxang/spark-clickhouse-connector
that referenced
this pull request
Jul 14, 2023
… and agg pushdown does not take effects (ClickHouse#256) Co-authored-by: eye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #255