Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JFrog Token is not detected #164

Closed
Tracked by #111
baruchiro opened this issue Aug 7, 2023 · 2 comments · Fixed by #170
Closed
Tracked by #111

JFrog Token is not detected #164

baruchiro opened this issue Aug 7, 2023 · 2 comments · Fixed by #170
Assignees
@binyamin2
Labels
good first issue Good for newcomers internal requirement Requirements from Checkmarx internally

Comments

@baruchiro
Copy link
Contributor

baruchiro commented Aug 7, 2023 •
edited
Loading

AKCp9nGFo4jMzsA32Qg6DrjqEbyNBn1MuZbtyW1bQAFqSp6v2WMCagbzbPbChqcr9yXAiJYka

We actually find JFrog tokens by the generic rule, but I added a JFrog-specific rule here: gitleaks/gitleaks#1233

My PR to gitleaks is already merged. We need to consume gitleaks with a specific commit hash that includes gitleaks/gitleaks#1233.

After that, please use my branch missing-secrets to add a test for the JFROG token to make sure it is detected.
@baruchiro baruchiro mentioned this issue Aug 7, 2023
Open
19 tasks
@baruchiro baruchiro added good first issue Good for newcomers internal requirement Requirements from Checkmarx internally labels Aug 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in 2ms Aug 7, 2023
@baruchiro baruchiro changed the title This JFrog Token is not detected: AKCp9nGFo4jMzsA32Qg6DrjqEbyNBn1MuZbtyW1bQAFqSp6v2WMCagbzbPbChqcr9yXAiJYka JFrog Token is not detected Aug 7, 2023
@binyamin2
Copy link
Contributor

Hi, please assign it to me, it's my first time, but I will try to do it.

@baruchiro
Copy link
Contributor Author

Good luck!

@binyamin2 binyamin2 mentioned this issue Aug 14, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 16, 2023
@binyamin2
fix: jfrog token is not detected (#170)
e6e8b8e 
<!-- 
Thanks for contributing to 2ms by offering a pull request.
-->

Closes #164

**Proposed Changes**
-Changing the version of "gitleaks" dependency to commit "add JFrog API
and Identity keys #1233"
-Add tests for Jfrog ( I take it from the branch "missing-secrets")
-Update the functions of "Slack" in secrets.go (I didn't know what is
the appropriate tag for each one)

I submit this contribution under the Apache-2.0 license.

---------

Co-authored-by: Baruch Odem <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in 2ms Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binyamin2 binyamin2

Labels
good first issue Good for newcomers internal requirement Requirements from Checkmarx internally
Projects
2ms
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jfrog token is not detected
2 participants
@baruchiro @binyamin2