Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loggingpath to settings.json #193

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

1Jesper1
Copy link
Contributor

@1Jesper1 1Jesper1 commented Jul 2, 2021

  1. Maybe we can combine LoggingPathConfigurator and MessagePathConfigurator, because of duplicate code.
  2. BootstrapLogger still uses Path.Combine(AppConstants.DataDirectory, "Logs", "PapercutCoreFailure.json");, maybe we can use CreateBootstrapLogger https://nblumhardt.com/2020/10/bootstrap-logger/ , so we can use the settings.config or services?

Can we create tests for this?
PS: Is ServerPathTemplateProviderService in Papercut.Services.Services used?

@1Jesper1 1Jesper1 mentioned this pull request Jul 2, 2021
@AppVeyorBot
Copy link

@Jaben
Copy link
Member

Jaben commented Sep 2, 2021

Thanks @1Jesper1 for the PR. I'm finally reviewing it. I do have a couple of fixes before I can merge.

@Jaben Jaben self-assigned this Sep 2, 2021
@Jaben Jaben merged commit 95b0cd8 into ChangemakerStudios:develop Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants