Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggingPathConfigurator
andMessagePathConfigurator
, because of duplicate code.Path.Combine(AppConstants.DataDirectory, "Logs", "PapercutCoreFailure.json");
, maybe we can useCreateBootstrapLogger
https://nblumhardt.com/2020/10/bootstrap-logger/ , so we can use the settings.config or services?Can we create tests for this?
PS: Is ServerPathTemplateProviderService in Papercut.Services.Services used?